-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-removed deprecated depositsStatus key from account status #8755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shendy-a8c
added
the
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
label
May 2, 2024
shendy-a8c
changed the title
Re-removed deprecated deposit_status key from account status
Re-removed deprecated depositsStatus key from account status
May 2, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
shendy-a8c
added
pr: needs review
and removed
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
labels
May 13, 2024
A fix to the failed unit test has been deployed (read https://github.com/Automattic/multiwoo/issues/1125#issuecomment-2104872138), so this is good to merge. |
jessy-p
approved these changes
May 15, 2024
hsingyuc
pushed a commit
that referenced
this pull request
May 16, 2024
Co-authored-by: Jessy Pappachan <32092402+jessy-p@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4710
Changes proposed in this Pull Request
Removed deprecated deposit_status key from Account status.
Note:
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge